Fix build #37
Closed
Fix build #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3945c52.
|
Hi, I'm not currently accepting pull requests for this project as I don't have the time to manage it. Thanks for your kind words and congrats, your C# port looks awesome :) ! |
|
Thanks for the PR. Eventhough it's closed, I was able to fetch it using this command:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the shader not working and also the build not working.
out/build/x64-Debug/(for me), so the root directory is actually 3 directories up.I'm also in the process of porting this engine to C#, with full credit to this repo and the assets used in it. I am not going to port some stuff due to different reasons.
Edit: It's basically done if you're curious: https://github.com/Kermalis/HybridRenderingEngine-CS
This is an awesome project :)