Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fullscreen editor on landscape #1686

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

itsvks19
Copy link
Contributor

No description provided.

@itsvks19 itsvks19 marked this pull request as draft January 28, 2024 13:15
@itsaky itsaky linked an issue Jan 28, 2024 that may be closed by this pull request
5 tasks
@itsvks19 itsvks19 marked this pull request as ready for review January 28, 2024 14:04
@itsaky
Copy link
Member

itsaky commented Feb 5, 2024

There are some issues with this implementation that I have listed below, with steps to reproduce the issues. I didn't debug these issues myself so I can't provide the exact cause of the same :

  1. When in landscape mode, if the user opens a file and tries to bring up the keyboard by clicking anywhere in the editor, the editor becomes invisible (or gone, or maybe overlapped by any other view? idk!). This bug doesn't occur if the file is opened first and then the orientation is changed.
    • Open a project, then switch to landscape orientation.
    • Open a file.
    • Click anywhere in the editor to show the keyboard.
    • The editor will be invisible now.
  2. If the user changes the orientation while the keyboard is visible, the action bar is always hidden.
    • Open a project, then switch to landscape orientation.
    • Open a file.
    • Click anywhere in the editor to show the keyboard.
    • Without closing the keyboard, switch to portrait orientation.
    • The action bar will be hidden, instead of being shown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fullscreen editor
2 participants