Adjusted padding to better align number and simplified menu option slightly #2484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was a bug that was fixed in ac0a07f (sync group was not saved at all) |
|
Great. I like it. It's kind of the perfect type of new
functionality. Existing users who dont want it will barely notice it. But
some will notice the little number and go exploring to see why it's there.
…___________________________
*www.TenOutOfTen.org* <https://www.TenOutOfTen.org>
***@***.***
(+61) 0477 174 193 (Australia)
(+95) 09 250018669 (Myanmar)
On Sun, 29 Jan 2023 at 20:44, Tuomas Airaksinen ***@***.***> wrote:
The only other change I might suggest is having a new window open in the
same sync group. At present it always opens in Sync Group 1. It feels like
it should keep it's number. Having not used it yet I don't know if that is
a good idea though.
This was a bug that was fixed in ac0a07f
<ac0a07f>
(sync group was not saved at all)
—
Reply to this email directly, view it on GitHub
<#2484 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADKGTJV77SDMXUMEZIF4ORLWUZ3NDANCNFSM6AAAAAAUJURG7I>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
I actually aligned number intentionally so that it looks a little bit like a subscript to the sync symbol. What do you think? |
|
I didn't realise you had asked a question here. And I can't remember what I changed and how it looked. So you can cancel this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That feels better to me.
I like the sync group option. It doesnt really change existing functionality unless someone goes hunting for the option. Limiting to 4 groups is good too. I imagine this is most useful on tablet.
The only other change I might suggest is having a new window open in the same sync group. At present it always opens in Sync Group 1. It feels like it should keep it's number. Having not used it yet I don't know if that is a good idea though.