MNT-17527 Add support for annotation layer #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g links) to the OOTB PDFJS viewer.
|
Thanks for the PR! As referenced in the title, we've already got an MNT ticket for this: https://issues.alfresco.com/jira/browse/MNT-17527 - so will continue the discussion there about getting this fix reviewed and merged. |
douglascrp
reviewed
Sep 14, 2017
| @@ -1902,7 +1913,7 @@ | |||
| this.textLayerDiv = null; | |||
| this.config = config || {}; | |||
| this.textContent = null; | |||
| this.textLayerDiv = null; | |||
| this.annotationLayerDiv = null; | |||
There was a problem hiding this comment.
It seems you removed the parameter variable textLayerDiv here
There was a problem hiding this comment.
Forget it. You created a copy of the original one, and then changed it to annotationLayerDiv... sorry
There was a problem hiding this comment.
@douglascrp well... I reused an existing (duplicate property), instead of adding a new one..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to have clickable links in PDFJS viewer in Alfresco Share, the annotation layer needs to be rendered. In this PR, I added the support for this feature and added an activation flag (defaulting to true) as discussed with @esplinr.
Alfresco can switch that back to false by default and have a config entry (in share-config-custom.xml for instance) defining that setting.
IMHO it should be active by default (as it was with the swf previews back in 4.x) and customers can opt out of the feature by a simple extension setting the activation flag to false.