-
Notifications
You must be signed in to change notification settings - Fork 475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS-7681] Add Keycloak compatibility and configuration for ACS 7.3.2 #1478
Conversation
I am not sure about the position of this Keycloak configuration instruction. |
The link to |
3. Navigate to the **Clients** section. | ||
4. Select the client that is used by Share according to the `aims.resource` property. | ||
|
||
> **Note:** When using the Identity Service for authentication, see [Configure Alfresco Share Properties]({% link identity-service/latest/tutorial/sso/ldap.md %}#step-5-configure-alfresco-share-properties). When using Keycloak for authentication, see . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no reason to mention Identity Service here as this workaround is only necessary for vanilla Keycloak. Also Identity Service is reaching EoL in September 2024.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deleted the note and left only reference to add a link to aims.resources
in Keycloak Tutorial.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a link to an old keycloak docs version (https://www.keycloak.org/docs/4.8/..
) - we might need to update the version to latest instead of 4.8
or at least the version we're compatible with, as long as that page exists in the version-specific files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The APS 2.4 page in the ACS 7.4 PR links to /docs/latest/..
so that might be the best option for now? @dsibilio
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see that in following versions of ACS where the Keycloak Adapters have been replaced by Spring Security this link had been entirely removed. I suspect the feature of mapping these Keycloak properties automagically 1 by 1 only happens because of the Keycloak Adapters and, normally, it would be best to tag this link to the same version as the Keycloak Adapters in ACS 7.3 (18.0.0)
.
Given that the Keycloak team has apparently completely unpublished the documentation for versions < 21, we don't have the ability to link to that anyways (ref: keycloak/keycloak#23210)
So we might as well link to the latest
, hoping that the Java Adapter Config didn't change too much in the meanwhile. Pointing to 21 seems meaningless as Keycloak will seemingly keep unpublishing their docs versions one by one after a while and we'll be back to square one.
cc: @pzhyland
* [DOCS-7681] Add Keycloak compatibility and configuration for ACS 7.3.2 (#1478) * [DOCS-7681] Update Keycloak compatibility matrix with message * [DOCS-7681] Fix tab * [DOCS-7681] Fix a link * [DOCS-7681] Add note * [DOCS-7681] Fix a link * [DOCS-7681] Fix a link * [DOCS-7681] Add suggestions * [DOCS-7681] Update Keycloak link * [DOCS-7690] Add environment compatibilities * [DOCS-7706] Update ACS 7.3.2 Supported Platfroms for Alfresco Transformation Service 4.1.2 (#1496) * [DOCS-7710][DOCS-7723] Add & update compatibility in ACS 7.3 (#1500) * [DOCS-7710] Add Alfresco Desktop Sync 1.18 to ACS 7.3 * [DOCS-7723] Update Sync Service 3.11.3 compatibility to ACS 7.3 * [DOCS-7686] Update compatible Salesforce Connector & Google Docs * [DOCS-7708] Add Intelligence Services 3.1.3 compatibility to ACS 7.3 --------- Co-authored-by: Monika Rutkowska <[email protected]> Co-authored-by: Adelaide Nxumalo <[email protected]>
No description provided.