hyprland/workspaces: Add enable-bar-scroll option
#3088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VAWVAW
force-pushed
the
hyprland-bar-scroll
branch
from
9666b33
to
99ceaae
Compare
VAWVAW
force-pushed
the
hyprland-bar-scroll
branch
from
99ceaae
to
fed413b
Compare
But why would you use both at the same time? 😄 |
|
Hey guys, can we please have this merged, I tested it and I need the functionality. I want to run the upstream version and not my locally built version, so that I get all updates. |
zjeffer
reviewed
May 12, 2024
zjeffer
reviewed
May 12, 2024
zjeffer
reviewed
May 12, 2024
zjeffer
approved these changes
May 12, 2024
|
I'd like to test this out but there are way too many conflicts since the workspaces.cpp file was split up into two files. Can you fix the conflicts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the option to capture scroll events for hyprland workspaces on the whole bar like it works with sway.
When using this, I had a bug that if I enable bar scroll on both hyprland and sway and put
sway/workspacesafterhyprland/workspacesinmodules-leftthe bar scroll would no longer work on sway. When puttingsway/workspacesfirst, it works on hyprland and sway. I don't know enough to track this down though.