Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic refactoring #109

Merged
merged 13 commits into from
Nov 11, 2023
Merged

Generic refactoring #109

merged 13 commits into from
Nov 11, 2023

Conversation

AlexPresso
Copy link
Owner

@AlexPresso AlexPresso commented Nov 10, 2023

This PR aims to help the VideoStation's patch and MediaServer's patch to work together (i.e. you want to patch VideoStation + MediaServer).

Changes:

  • Make CodecPack (Advanced Media Extensions) patch standalone : CodecPack is not anymore relying on VideoStation's patched files to work. It's safer this way, as VideoStation can be removed without breaking CodecPack features.
  • CodecPack patched ffmpeg files (ffmpeg33, ffmpeg41 and/or ffmpeg27) are now trying with CodecPack default ffmpeg files before trying to use SynoCommunity's ffmpeg. Again, it's safer for other applications also relying on CodecPack's ffmpeg to work.
  • Group gstreamer patched libraries and plugins into same directory to make it easier and safer to remove.
  • Make the wrappers work in a more generic way
  • Code cleaning

@AlexPresso AlexPresso changed the title WIP: Generic refactoring Generic refactoring Nov 10, 2023
@AlexPresso
Copy link
Owner Author

Hey there,

If some people wants to test this PR, please follow these instructions:

  • uninstall the patch : curl https://raw.githubusercontent.com/AlexPresso/VideoStation-FFMPEG-Patcher/main/patcher.sh | bash -s -- -a unpatch
  • install the new patch curl https://raw.githubusercontent.com/AlexPresso/VideoStation-FFMPEG-Patcher/generic_refactor/patcher.sh | bash -s -- -a patch -b generic_refactor

Please inform me of any issue you could have

@AlexPresso AlexPresso added looking for testers Loogin for testers testing and removed testing labels Nov 10, 2023
@AlexPresso
Copy link
Owner Author

Tested OK on my DS218Play

@AlexPresso
Copy link
Owner Author

Hi @Fabian1601 ; @djhibee and @ner00
Sorry to ping you, but if you mind testing this new patcher using the previous comment procedure, it would be highly appreciated

@Fabian1601
Copy link

Fabian1601 commented Nov 10, 2023

Hello Alex,

im already on it but as soon as it restarts in script videostation it reindexes all files.
It i start in the meantime the install script and it restarts videostation again it trashes all my database.
But the Problem has always been there and nothing to do with your script.
It just takes a Moment 😉

@AlexPresso
Copy link
Owner Author

AlexPresso commented Nov 10, 2023

Yeah it also happens to me sometimes ahah, I have to reindex everything, it's quite annoying, but I guess Synology don't want to work on fixing that

Thank you very much :)

@Fabian1601
Copy link

Fabian1601 commented Nov 10, 2023

So script ran smoothly and no problems so far. Playback is fine and i have a file in offline transcoding but it still needs about 20min to finish 👍

update:
Transcoding finished without any issue 👌

@AlexPresso AlexPresso closed this Nov 10, 2023
@AlexPresso AlexPresso deleted the generic_refactor branch November 10, 2023 22:10
@AlexPresso AlexPresso restored the generic_refactor branch November 10, 2023 22:14
@AlexPresso AlexPresso reopened this Nov 10, 2023
@AlexPresso AlexPresso removed the looking for testers Loogin for testers label Nov 11, 2023
@AlexPresso AlexPresso merged commit 610cb3f into main Nov 11, 2023
2 checks passed
@AlexPresso AlexPresso deleted the generic_refactor branch November 11, 2023 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants