Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure package can be built and tested with Python 3.11 #97

Merged
merged 5 commits into from
Nov 7, 2022

Conversation

aris-aiven
Copy link
Contributor

Python 3.11 was released recently, and myhoard aims to support it.

@aris-aiven aris-aiven changed the title Ensure package can be built and test with Python 3.11 Ensure package can be built and tested with Python 3.11 Nov 3, 2022
@aris-aiven
Copy link
Contributor Author

The linter error is due to pylint-dev/pylint#6535

@aris-aiven
Copy link
Contributor Author

The unit test error was due to a change to Enum.format behaviour (see https://docs.python.org/3/whatsnew/3.11.html)

@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2022

Codecov Report

Base: 76.22% // Head: 75.81% // Decreases project coverage by -0.40% ⚠️

Coverage data is based on head (e1dbdb7) compared to base (a73efd4).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head e1dbdb7 differs from pull request most recent head fbc241e. Consider uploading reports for the commit fbc241e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #97      +/-   ##
==========================================
- Coverage   76.22%   75.81%   -0.41%     
==========================================
  Files          16       16              
  Lines        3903     3903              
  Branches      896      917      +21     
==========================================
- Hits         2975     2959      -16     
- Misses        714      733      +19     
+ Partials      214      211       -3     
Impacted Files Coverage Δ
myhoard/restore_coordinator.py 74.52% <ø> (-0.88%) ⬇️
version.py 0.00% <ø> (ø)
myhoard/controller.py 78.76% <100.00%> (-0.31%) ⬇️
myhoard/basebackup_operation.py 91.21% <0.00%> (-3.42%) ⬇️
myhoard/basebackup_restore_operation.py 80.28% <0.00%> (-0.49%) ⬇️
myhoard/update_mysql_environment.py 0.00% <0.00%> (ø)
myhoard/backup_stream.py 76.94% <0.00%> (+0.31%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@aris-aiven aris-aiven marked this pull request as ready for review November 3, 2022 20:11
@aris-aiven aris-aiven requested a review from a team as a code owner November 3, 2022 20:11
@aris-aiven aris-aiven force-pushed the aris-python311 branch 6 times, most recently from 22b7a08 to ecaedab Compare November 3, 2022 21:28
@nicois
Copy link
Contributor

nicois commented Nov 3, 2022

Can we remove support for older python versions too? At least allowing us to use python3.8 syntax would be nice.
Versions of python prior to 3.10 are only receiving security updates; it would be reasonable for us to do likewise.

https://devguide.python.org/versions/

Copy link
Contributor

@kmichel-aiven kmichel-aiven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are probably all good, but most of them are not described and mixed together in the same commit, this should be split and explained a little more.

myhoard/controller.py Show resolved Hide resolved
version.py Show resolved Hide resolved
@kmichel-aiven
Copy link
Contributor

Can we remove support for older python versions too? At least allowing us to use python3.8 syntax would be nice. Versions of python prior to 3.10 are only receiving security updates; it would be reasonable for us to do likewise.

https://devguide.python.org/versions/

Removing 3.8 and older sounds reasonable.
I wouldn't remove 3.9 since it's still the current version in the latest stable debian (bullseye) and latest RHEL (9).

@aris-aiven aris-aiven dismissed kmichel-aiven’s stale review November 4, 2022 11:25

Python versions pre-3.9 have been deprecated, the PR has been split into smaller commits as requested, and the test matrix was updated to test 3.11 with newer MySQL and Percona Server version.

@aris-aiven aris-aiven requested a review from a team November 4, 2022 18:01
@kmichel-aiven kmichel-aiven merged commit 8644026 into master Nov 7, 2022
@kmichel-aiven kmichel-aiven deleted the aris-python311 branch November 7, 2022 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants