-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
POC: integrate with the new Google Pay beta library #1438
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JlUgia
reviewed
Feb 2, 2024
googlepay/src/main/java/com/adyen/checkout/googlepay/internal/ui/DefaultGooglePayDelegate.kt
Outdated
Show resolved
Hide resolved
5ca5a77
to
d9551c9
Compare
d9551c9
to
18d8bd7
Compare
…-android into test/google_pay_beta # Conflicts: # googlepay/src/main/java/com/adyen/checkout/googlepay/internal/provider/GooglePayComponentProvider.kt # googlepay/src/main/java/com/adyen/checkout/googlepay/internal/ui/DefaultGooglePayDelegate.kt
…auncher COAND-855
18d8bd7
to
7cc5181
Compare
…-android into test/google_pay_beta # Conflicts: # googlepay/src/main/java/com/adyen/checkout/googlepay/internal/ui/DefaultGooglePayDelegate.kt # gradle/verification-metadata.xml
…les avoiding the nullifying cycle after actions are handled
…k to the viewModel. Instead, the payment operation can be started right away
…e call with the result does not depend on the Google Pay component)
Draft proposal to update the Google Pay section of the sample application
|
We are redesigning the whole Google Pay component flow, closing this PR for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is an initial effort to integrate with the beta version of the upcoming
19.3.0
Google Pay library. The main benefit is removing the dependency to the deprecatedonActivityResult
.Checklist