Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Second draft of file bundle adapter docs. #1709

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

ssteinbach
Copy link
Collaborator

Following conversation with @darbyjohnston, an attempt to clean up and clarify the documentation for the file bundle adpaters.

@ssteinbach ssteinbach added this to the Public Beta 16 milestone Mar 8, 2024

### Convert an otio into a zip bundle
- absolute path: "file:///path/to/some/file" (encodes "/path/to/some/file")
- relative path: "path/to/some/file" (assumes the path is relative to the current working directory when invoking the adapter on the source timeline).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the current working directory refer the location of the timeline or where the command is being run?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

an update on this - it would appear that it refers to the cwd of the command being run, but I think it should probably be relative to the location of the timeline. The final resulting paths are relative to the root of the bundle.


The file bundle adapters expect the `target_url` field of the `media_reference` to be in one of two forms (as produced by python's urlparse library):
OTIOZ (adds the version.txt file and is encoded in a zipfile):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a note here that the content.otio and version.txt files are compressed and the media is uncompressed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good suggestion!

@codecov-commenter
Copy link

codecov-commenter commented Apr 6, 2024

Codecov Report

Attention: Patch coverage is 88.23529% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 84.12%. Comparing base (2b9c3a4) to head (c47eeb9).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1709      +/-   ##
==========================================
+ Coverage   79.95%   84.12%   +4.16%     
==========================================
  Files         197      198       +1     
  Lines       21879    22242     +363     
  Branches     4342     4688     +346     
==========================================
+ Hits        17494    18710    +1216     
- Misses       2252     2610     +358     
+ Partials     2133      922    -1211     
Flag Coverage Δ
py-unittests 84.12% <88.23%> (+4.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ineio/opentimelineio/adapters/file_bundle_utils.py 72.30% <100.00%> (ø)
src/py-opentimelineio/opentimelineio/url_utils.py 85.71% <86.66%> (+0.52%) ⬆️

... and 107 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d875e7...c47eeb9. Read the comment docs.

@ssteinbach ssteinbach marked this pull request as draft April 11, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants