Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove env var logic for pre-setshot #935

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Remove env var logic for pre-setshot #935

wants to merge 3 commits into from

Conversation

larsbijl
Copy link
Contributor

@larsbijl larsbijl commented Mar 7, 2021

Logic seems SPI specific, remove it from the opensource.

Closes #548

Remove env var logic for pre-setshot
61a3668 
Logic seems SPI specific, remove it from the opensource.

Closes AcademySoftwareFoundation#548
DiegoTavares
DiegoTavares approved these changes Mar 31, 2021
View reviewed changes
Copy link
Collaborator

@DiegoTavares DiegoTavares left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree this seems to be SPI specific. Changes look right, but some pipeline steps are failing.

@bcipriano
Copy link
Collaborator

Thanks Diego. Code changes look good, just need to resolve the merge conflicts here.

@larsbijl larsbijl requested a review from splhack as a code owner May 3, 2024 20:46
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

CLA Missing ID CLA Not Signed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiegoTavares DiegoTavares DiegoTavares approved these changes

@bcipriano bcipriano Awaiting requested review from bcipriano bcipriano is a code owner

@gregdenton gregdenton Awaiting requested review from gregdenton

@IdrisMiles IdrisMiles Awaiting requested review from IdrisMiles

@jrray jrray Awaiting requested review from jrray

@smith1511 smith1511 Awaiting requested review from smith1511

@splhack splhack Awaiting requested review from splhack

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove pre-setshot environment logic from outliner
3 participants
@larsbijl @bcipriano @DiegoTavares