Add colour theme's #842
Open
Add colour theme's #842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add option to change between them from the menu. Closes AcademySoftwareFoundation#841
larsbijl
requested review from
bcipriano,
DiegoTavares,
gregdenton,
jrray and
smith1511
as code owners
bcipriano
reviewed
Nov 24, 2020
There was a problem hiding this comment.
Great change!
Have you had a chance to test this out on Windows? I'm seeing the Windows-specific overrides in there and want to make sure we're not breaking anything for those folks.
Keeping the existing single-style Windows override is probably not a good idea but maybe there's a way to add that override to the menu you've added (if it's actually needed).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add option to change between them from the menu.
Original
New Dark Theme
Darkblue
Rainbow
light
Light Pink
Closes #841