CueGui, fix limit assignation bug #1291
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KernAttila
requested review from
bcipriano,
gregdenton,
jrray,
smith1511,
larsbijl,
DiegoTavares,
IdrisMiles and
splhack
as code owners
|
/easycla |
KernAttila
force-pushed
the
cuegui-fix-limit-assign
branch
from
9963e56
to
669d6c4
Compare
… limit names with space between two words.
|
Sorry, got mixed up between my work and personnal account. I rebased the commits with the proper author. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link the Issue(s) this Pull Request is related to.
When a limit has a space in its name, it is not possible to assign it to a layer in cueGui.
Test:
Summarize your change.
Fix: do not strip spaces in the UI
The fail comes from str.isalnum() which returns False when a string contains a whitespace.
Fix: strip limit name when renaming (already done when creating a new one)