-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement feature to override frame state display text/color in UI #1246
base: master
Are you sure you want to change the base?
Implement feature to override frame state display text/color in UI #1246
Conversation
… can use for overrides
…o frame_state_display_override_GH
Thanks for sending this! Very cool feature. I'm a bit confused how this is meant to work. So the display overrides are set on a per-frame basis. I see there's code for getting/setting overrides for a frame, but what is meant to actually create these overrides? Do you have some custom code that isn't included here? |
This feature came from an internal request where the team wanted to end renders based on specific conditions on a given frame and have a visual way of seeing which frames "timed out" vs. finished normally. So the thought is whatever app is running in the frame or some external app monitoring frames could use this feature to override the displayed state setting when a specific event happens (a particular exception/failure, run time exceeds a set time, etc). |
Ok, got it. So the creation of a display override is not contained within OpenCue itself, but instead triggered by some external tool -- either something on the RQD host or some other tool entirely. I'm wondering if there's a way we could build this functionality fully into OpenCue, so that an external tool isn't needed. Is there enough information stored in the database to make the decision that a display override is warranted? If it's We recently introduced Going further, is this a change that could be implemented entirely via Let me know what you think. |
@bcipriano we can discuss this on our TSC meeting. IMO this feature works well as it is and is ready to be merged. I also agree it can be expanded to become something configurable for other use cases. To make the feature easier to understand we could add a change in the documentation to explain its context. Maybe a new topic on https://www.opencue.io/docs/user-guides/ |
…o frame_state_display_override_GH
… updates are received on the UI side
…o frame_state_display_override_GH
The scheduled task to remove old jobs has been failing for jobs with frames that used the new override feature due to a foreign key not being handled at the delete trigger.
…o frame_state_display_override_GH
Ready to be merged IMO. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good. I think we ended up with an extra database migration in this PR? The V30
migration doesn't look related.
…o frame_state_display_override_GH
….com:rbehrens/OpenCue into frame_state_display_override_GH
@bcipriano can you review the changes you had requested? |
Looks like we've still got a stray |
Give users ability to customize frame status display in UI in case they want to show a different text/color for whatever reason
e.g. a frame fails due to a timeout condition vs other errors.