cuegui: Make frames and layers readonly after job is done #1167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akim-ruslanov
requested review from
bcipriano,
gregdenton,
jrray,
smith1511,
larsbijl,
DiegoTavares,
IdrisMiles and
splhack
as code owners
akim-ruslanov
changed the title
akim-ruslanov
force-pushed
the
cuegui_readonly
branch
3 times, most recently
from
008419b
to
bd96fc7
Compare
DiegoTavares
reviewed
Jul 8, 2022
akim-ruslanov
force-pushed
the
cuegui_readonly
branch
from
bd96fc7
to
c0475a0
Compare
akim-ruslanov
force-pushed
the
cuegui_readonly
branch
from
c0475a0
to
48151c6
Compare
bcipriano
approved these changes
Jul 12, 2022
Signed-off-by: Diego Tavares da Silva <[email protected]>
DiegoTavares
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link the Issue(s) this Pull Request is related to.
Retrying a frame in a finished job will cause the frame to go back into the waiting state and the job will return to the cue. This even bypasses checks on duplicate job names, so two jobs with the same name can be running at the same time. Hence, it should be disallowed to retry frames on finished jobs, and the finished jobs should be read only.
Summarize your change.
The cuegui buttons that retry frames, edit dependencies, reorder, etc. are grayed out if the jobs is finished. This should make sure we treat the job as read only once the job is finished.
The new feature can be toggled through adding a prop to
cue_resources.yaml. By default, the feature will be off and can only be toggled on by explicitly including the prop.