Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pre-setshot environment logic from outliner #548

Open
larsbijl opened this issue Nov 24, 2019 · 3 comments · May be fixed by #935
Open

Remove pre-setshot environment logic from outliner #548

larsbijl opened this issue Nov 24, 2019 · 3 comments · May be fixed by #935
Assignees
@larsbijl
Labels
enhancement Improvement to an existing feature triaged Issue has been screened and prioritized by a project lead

Comments

@larsbijl
Copy link
Contributor

Describe the enhancement
In the outliner, environment variables can be added job that will be used in all layers.
This uses a extra pre-setshot boolean to decided if it should be sent to cuebot.

What's the intended use case for having these but not having them submitted to cuebot?
@larsbijl larsbijl added the enhancement Improvement to an existing feature label Nov 24, 2019
@larsbijl
Copy link
Contributor Author

@dinesy

@dinesy
Copy link

dinesy commented Jan 16, 2020

Is there a line of code to reference? If I had to guess, it sounds like it was for some workaround for a legacy pipeline.

@larsbijl
Copy link
Contributor Author

https://github.com/AcademySoftwareFoundation/OpenCue/blob/master/pyoutline/outline/backend/cue.py#L235

@larsbijl larsbijl self-assigned this Jan 23, 2020
@bcipriano bcipriano added the triaged Issue has been screened and prioritized by a project lead label Jan 24, 2020
larsbijl pushed a commit to larsbijl/OpenCue that referenced this issue Mar 7, 2021
Remove env var logic for pre-setshot
61a3668 
Logic seems SPI specific, remove it from the opensource.

Closes AcademySoftwareFoundation#548
@larsbijl larsbijl linked a pull request Mar 7, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@larsbijl larsbijl

Labels
enhancement Improvement to an existing feature triaged Issue has been screened and prioritized by a project lead
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove env var logic for pre-setshot larsbijl/OpenCue
3 participants
@larsbijl @bcipriano @dinesy