Skip to content

Commit

Permalink
fix(js-sdk): Resolve build error (#88)
Browse files Browse the repository at this point in the history
  • Loading branch information
wilsonianb committed Jan 9, 2024
1 parent 4ed64c6 commit 3bf0684
Show file tree
Hide file tree
Showing 5 changed files with 70 additions and 32 deletions.
16 changes: 16 additions & 0 deletions .github/workflows/js-sdk-build.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
name: Build JS SDK

on:
pull_request:
types:
- opened
- synchronize
- reopened
paths:
- 'packages/sdk/js/**'

jobs:
build:
uses: ./.github/workflows/js-sdk-shared.yaml
with:
should-publish: false
33 changes: 3 additions & 30 deletions .github/workflows/js-sdk-publish.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,33 +9,6 @@ permissions:

jobs:
publish:
name: Build and publish SDK to NPM
runs-on: ubuntu-20.04
steps:
- name: Checkout repository
uses: actions/checkout@v3
with:
submodules: true

- name: Setup Node
uses: actions/setup-node@v3
with:
node-version: '16.x'
registry-url: 'https://registry.npmjs.org'
cache: npm
cache-dependency-path: package-lock.json

- name: Install dependencies
working-directory: ./packages/sdk/js/
run: npm ci

- name: Publish package
run: npm publish --access=public
working-directory: ./packages/sdk/js/
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}

- name: Release
uses: softprops/action-gh-release@v1
with:
generate_release_notes: true
uses: ./.github/workflows/js-sdk-shared.yaml
with:
should-publish: true
46 changes: 46 additions & 0 deletions .github/workflows/js-sdk-shared.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
name: Build and Publish JS SDK Package

on:
workflow_call:
inputs:
should-publish:
required: false
type: boolean
default: false

jobs:
build:
name: Build and optionally publish SDK to NPM
runs-on: ubuntu-20.04
steps:
- name: Checkout repository
uses: actions/checkout@v3

- name: Setup Node
uses: actions/setup-node@v3
with:
node-version: '16.x'
registry-url: 'https://registry.npmjs.org'
cache: npm
cache-dependency-path: package-lock.json

- name: Install dependencies
working-directory: ./packages/sdk/js/
run: npm ci

- name: Build package
working-directory: ./packages/sdk/js/
run: npm run build

- name: Publish package
if: ${{ inputs.should-publish }}
run: npm publish --access=public
working-directory: ./packages/sdk/js/
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}

- name: Release
if: ${{ inputs.should-publish }}
uses: softprops/action-gh-release@v1
with:
generate_release_notes: true
2 changes: 1 addition & 1 deletion packages/sdk/js/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ You can find more info and examples in the [docs](https://agentprotocol.ai/sdks/

```bash
git clone https://github.com/AI-Engineers-Foundation/agent-protocol
cd agent-protocol/sdk/js
cd agent-protocol/packages/sdk/js
npm install
npm run build
```
5 changes: 4 additions & 1 deletion packages/sdk/js/src/agent.ts
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,10 @@ export const createArtifact = async (
relative_path: relativePath ?? null,
created_at: Date.now().toString(),
}
task.artifacts = task.artifacts != null ?? []
task.artifacts =
task.artifacts !== null && task.artifacts !== undefined
? task.artifacts
: []
task.artifacts.push(artifact)

const artifactFolderPath = getArtifactPath(task.task_id, workspace, artifact)
Expand Down

0 comments on commit 3bf0684

Please sign in to comment.