Use tcp manager when "tcp_manager" feature is on #1675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s1341
changed the title
s1341
changed the title
|
I don't get this. LLMP TCP etc can coexist, we don't need a new feature |
|
I think the way to go here to avoid code reuse is a macro that define Launcher with different names (CentralizedLauncher, TCPLauncher etc) changing the trait bound to the different kind of managers |
|
Are you sure? |
|
Yes sounds good. We might also have other launchers for other managers in the future |
|
As long as we don't have a better idea, maybe we want to merge this anyway? It's useful to have a tcpmanager enabled launcher sometimes.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.