Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(ios) Update localizations #565

Merged
merged 3 commits into from
May 20, 2024
Merged

(ios) Update localizations #565

merged 3 commits into from
May 20, 2024

Conversation

robbiehanson
Copy link
Contributor

@robbiehanson robbiehanson commented May 16, 2024

Existing translations updated for iOS.

The following commands were run:

langtool translate --source ios --lang fr
langtool translate --source ios --lang es
langtool translate --source ios --lang cs
langtool translate --source ios --lang ar

Note that we are ready to add translations for all of these languages:
https://developers.deepl.com/docs/resources/supported-languages

@robbiehanson robbiehanson requested a review from dpad85 May 16, 2024 20:18
Copy link
Member

@dpad85 dpad85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For future localisation PRs, it would be better to split the localisation changes into several commits, 1 for each language updated (within the same PR). It will make the review easier since the localisation resources are all in the same file on iOS.

I also fixed a few strings in the French localisation and I've noticed that DeepL chose to use a more informal tone for the translation (https://en.wikipedia.org/wiki/T–V_distinction), which does not work well in this setting. I suspect it did the same for the other languages. The lang tool should be updated to use the prefer_more option for the DeepL formality setting (see https://developers.deepl.com/docs/api-reference/translate), so that we get a more formal localisation.

@robbiehanson robbiehanson merged commit 2171eca into master May 20, 2024
@robbiehanson robbiehanson deleted the update-localizations branch May 20, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants