Add new example keyboard, support for a new TRS socket, and minor fixes to the MCU generation. #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This socket may be only a TRS, but QMK does say that it should still work for split keyboards.
I've got a non-standard board, so need to use that parameter.
- New TRS socket support added - MCU can now support offset pins
|
Hey thanks for the contribution! I'm starting to work on this a little bit, starting with some refactors to improve modularity. Once I have those done I'll probably come in and rebase your changes on top of that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for this project! I used it last year to make a keyboard, and was always intending to add the changes to the upstream.
There was a minor bug with the MCU pin offset, but now that's accounted for and I can use my weird off brand pro-micro clones.
I also added support for a TRS socket, the PJ-324M, since that's what I had on hand at the time of construction.
And finally there's the new keyboard, which is a split preonic clone. I had to make some significant changes to the parameters.scad file, so I just moved the altered file to the example folder. I did keep the commented TRS socket settings in the original file, just for future reference.
Let me know if there are any changes I should make, and hopefully this PR is welcome.
Thanks again!