irc: do not bridge CTCP commands other than ACTION #2090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CTCP commands other than ACTION are designed for client-to-client interaction on IRC networks. Drop such messages when we receive them. Also get rid of a "CTCP_ACTION" handler in the handler registration. This 1) can't do anything (if anything, we wanted the string constant girc.CTCP_ACTION, which is "ACTION") 2) doesn't do anything in this context, because CTCP handlers are registered separately: https://github.com/lrstanley/girc/blob/f47717952bf9258e02eac14f1b9723bcf084e618/ctcp.go#L205 The PRIVMSG handler already listens to all CTCPs. Thanks to @lexande for the bug report (found on a live instance).
|
Code Climate has analyzed commit b862dc3 and detected 0 issues on this pull request. View more on Code Climate. |
|
Thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CTCP commands other than ACTION are designed for client-to-client interaction on IRC networks. Drop such messages when we receive them.
Also get rid of a "CTCP_ACTION" handler in the handler registration. The registration
girc.CTCP_ACTION, which is "ACTION")
registered separately:
https://github.com/lrstanley/girc/blob/f47717952bf9258e02eac14f1b9723bcf084e618/ctcp.go#L205
The PRIVMSG handler already listens to all CTCPs.
Thanks to @lexande for the bug report (found on a live instance).