Eliminate orphan objects #3732
Open
Eliminate orphan objects #3732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akostadinov
reviewed
Mar 21, 2024
akostadinov
reviewed
Mar 21, 2024
|
@akostadinov Updated |
mayorova
reviewed
Apr 10, 2024
| @@ -6,72 +6,27 @@ namespace :database do | |||
| puts 'Checking and removing orphaned objects...' | |||
|
|
|||
| # Tables to exclude from orphaned objects check | |||
| excluded_tables = ['accounts', 'audits', 'categories', 'category_types', 'cms_templates', 'legal_term_acceptances', 'legal_term_bindings', | |||
| 'legal_term_versions', 'proxy_logs', 'schema_migrations', 'service_cubert_infos', 'slugs', 'taggings', 'tags'] | |||
| excluded_tables = ['cms_templates'] | |||
There was a problem hiding this comment.
I think this exclusion can be removed
mayorova
reviewed
Apr 10, 2024
|
|
||
| if orphaned_objects.exists? | ||
| puts "Found orphaned objects in #{model.table_name}:" | ||
| orphaned_objects.each { |obj| puts "- ID: #{obj.id}, Tenant ID: #{obj.tenant_id}" } |
There was a problem hiding this comment.
I'd use find_each here instead of each to use batching.
jlledom
force-pushed
the
THREESCALE-10855-eliminate-orphan-objects
branch
from
89a470f
to
8e47c60
Compare
|
I rebased this, It was too old. |
jlledom
reviewed
Jun 10, 2024
| @@ -0,0 +1,32 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| namespace :database do | |||
There was a problem hiding this comment.
Shouldn't we use the db namespace? to be consistent with all other DB tasks
| @@ -6,72 +6,27 @@ namespace :database do | |||
| puts 'Checking and removing orphaned objects...' | |||
|
|
|||
| # Tables to exclude from orphaned objects check | |||
| excluded_tables = ['accounts', 'audits', 'categories', 'category_types', 'cms_templates', 'legal_term_acceptances', 'legal_term_bindings', | |||
| 'legal_term_versions', 'proxy_logs', 'schema_migrations', 'service_cubert_infos', 'slugs', 'taggings', 'tags'] | |||
| excluded_tables = ['cms_templates'] | |||
There was a problem hiding this comment.
I think this exclusion can be removed
|
|
||
| provider_account_ids = Account.where(provider: true).pluck(:id) | ||
|
|
||
| ActiveRecord::Base.descendants.each do |model| |
There was a problem hiding this comment.
Better this IMO:
Suggested change
| ActiveRecord::Base.descendants.each do |model| | |
| ApplicationRecord.descendants.each do |model| |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We need a rake task to go over all tables with the
tenant_idfield and make check whether that tenant still exists, reporting and optionally removing these on the way.complete description is in JIRA
Which issue(s) this PR fixes
https://issues.redhat.com/browse/THREESCALE-10855
Note: I have commented the deleted line for now but added puts so whoever will run it while reviewing can see the puts