Skip to content

Commit

Permalink
Updated light theme visited link colour to make text visible (#15406)
Browse files Browse the repository at this point in the history
* Added css for consistent underline and colour on links

* Added css variable to light theme

* Add old CSS property as fallback

* Changed visited link colour to purple for light theme

* Changed visited link colour in dark/light themes for better contrast

* Update packages/theme-dark-extension/style/variables.css

Co-authored-by: Michał Krassowski <[email protected]>

---------

Co-authored-by: EC2 Default User <[email protected]>
Co-authored-by: Frédéric Collonval <[email protected]>
Co-authored-by: Michał Krassowski <[email protected]>
  • Loading branch information
4 people committed Nov 29, 2023
1 parent 7622f44 commit eb07560
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion packages/theme-dark-extension/style/variables.css
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ all of MD as it is not optimized for dense, information rich UIs.
--jp-content-font-color2: rgba(255, 255, 255, 0.7);
--jp-content-font-color3: rgba(255, 255, 255, 0.5);
--jp-content-link-color: var(--md-blue-300);
--jp-content-link-visited-color: rgba(255, 255, 255, 0.3);
--jp-content-link-visited-color: var(--md-purple-300);
--jp-content-link-hover-color: var(--md-blue-400);
--jp-content-font-family: system-ui, -apple-system, blinkmacsystemfont,
'Segoe UI', helvetica, arial, sans-serif, 'Apple Color Emoji',
Expand Down
2 changes: 1 addition & 1 deletion packages/theme-light-extension/style/variables.css
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ all of MD as it is not optimized for dense, information rich UIs.
--jp-content-font-color2: rgba(0, 0, 0, 0.54);
--jp-content-font-color3: rgba(0, 0, 0, 0.38);
--jp-content-link-color: var(--md-blue-900);
--jp-content-link-visited-color: rgba(255, 255, 255, 0.3);
--jp-content-link-visited-color: var(--md-purple-700);
--jp-content-font-family: system-ui, -apple-system, blinkmacsystemfont,
'Segoe UI', helvetica, arial, sans-serif, 'Apple Color Emoji',
'Segoe UI Emoji', 'Segoe UI Symbol';
Expand Down

0 comments on commit eb07560

Please sign in to comment.