Fix sail port #68
Open
Fix sail port #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breart
requested changes
Nov 26, 2023
| @@ -46,7 +46,6 @@ public function metadata(Auth $auth) | |||
| public function acs(Auth $auth) | |||
| { | |||
| $errors = $auth->acs(); | |||
|
|
|||
There was a problem hiding this comment.
This change isn't relevant to the PR.
|
Looks good! Please remove one change related to the formatting and I'll merge this. |
|
Hi @raphaelcangucu , I'm eagerly waiting for your change to be part of the package. Would you please remove the change in src/Http/Controllers/Saml2Controller.php so breart can continue? Thank you for this fix! Best regards |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a small fix to work behind a Laravel Sail environment.
The SAIL always start the internal PHP server at port 80, and sometimes we run the SAIL on a different port, in my case it was to have 2 envs running in my machine. One for the IDP (port 80) and other to the SP (port 8888).
So the the code was getting always the 80 port from the internal PHP Server and trying to access the IDP server intead of the SP.
To fix this, I just added a new configuration at them config file to set the port if exists with the default value getting the APP_PORT from laravel's .env file.