Added saml session tracking for global logout #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natenatters
reviewed
Dec 1, 2022
|
@natenatters Good catch! Fixed that now. Would you consider adopting this PR now that it is resolved? |
|
@dmyers Just so you know, I dont maintain this package, I was just offering some advice :) |
|
@natenatters Sorry about that ping. I thought I saw you name on the maintainers somewhere. @breart Could you take a look at this if you have a moment please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps fix #34 - curious what you might think of this idea. This is modeled after the Onelogin Wordpress plugin which also does this.