Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connect-Core: get roles for organization #30

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Connect-Core: get roles for organization #30

wants to merge 2 commits into from

Conversation

rperez89
Copy link
Member

We need this in order to get the role description for each app permission

0xGabi
0xGabi approved these changes Feb 25, 2022
View reviewed changes
Copy link
Member

@0xGabi 0xGabi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@0xGabi
Copy link
Member

0xGabi commented Feb 25, 2022

Note we also have the roles on the App entity: https://github.com/1Hive/connect/blob/master/packages/connect-core/src/entities/App.ts#L87-L89

tmoutinho
tmoutinho approved these changes Feb 25, 2022
View reviewed changes
Copy link

@tmoutinho tmoutinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xGabi 0xGabi 0xGabi approved these changes

@tmoutinho tmoutinho tmoutinho approved these changes

@fabriziovigevani fabriziovigevani Awaiting requested review from fabriziovigevani

@kamikazebr kamikazebr Awaiting requested review from kamikazebr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rperez89 @0xGabi @tmoutinho @lint-action