Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LG-13199: Sprint 309 Translations #10642

Merged
merged 6 commits into from
May 23, 2024

Conversation

mdiarra3
Copy link
Member

🎫 Ticket

Link to the relevant ticket:
LG-13199

🛠 Summary of changes

Update content to match DOS translations

@mdiarra3 mdiarra3 requested a review from a team May 16, 2024 17:07
user_mailer.new_device_sign_in_before_2fa.info_p1_html.one: Su correo electrónico y su contraseña de %{app_name} se usaron para ingresar desde un nuevo dispositivo, pero <strong>la autenticación dio error</strong>.
user_mailer.new_device_sign_in_before_2fa.info_p1_html.other: Su correo electrónico y su contraseña de %{app_name} se usaron para ingresar desde un nuevo dispositivo, pero <strong>error al autenticar %{count} veces</strong>.
user_mailer.new_device_sign_in_before_2fa.info_p1_html.zero: Su correo electrónico y su contraseña de %{app_name} se usaron para ingresar desde un nuevo dispositivo, pero <strong>la autenticación dio error</strong>.
user_mailer.new_device_sign_in_before_2fa.info_p1_html.one: Su correo electrónico y contraseña de %{app_name} se usaron para iniciar sesión en un dispositivo nuevo, pero <strong>no se logró la autenticación</strong>.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This translation works but I need to be able to distinguish this in Chinese translations. so it has the same styling.

user_mailer.new_device_sign_in_before_2fa.info_p1_html.other: Su correo electrónico y su contraseña de %{app_name} se usaron para ingresar desde un nuevo dispositivo, pero <strong>error al autenticar %{count} veces</strong>.
user_mailer.new_device_sign_in_before_2fa.info_p1_html.zero: Su correo electrónico y su contraseña de %{app_name} se usaron para ingresar desde un nuevo dispositivo, pero <strong>la autenticación dio error</strong>.
user_mailer.new_device_sign_in_before_2fa.info_p1_html.one: Su correo electrónico y contraseña de %{app_name} se usaron para iniciar sesión en un dispositivo nuevo, pero <strong>no se logró la autenticación</strong>.
user_mailer.new_device_sign_in_before_2fa.info_p1_html.other: Su correo electrónico y contraseña de %{app_name} se usaron para iniciar sesión en un dispositivo nuevo, pero <strong>error al autenticar %{count} veces</strong>.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also the way this is written for multiple attempts instead of one failed attempt

@mdiarra3 mdiarra3 marked this pull request as ready for review May 17, 2024 14:33
@mdiarra3 mdiarra3 changed the title changelog: User-Facing Improvements, Authentication, Translations updates for DOS LG-13199: Sprint 309 Translations May 21, 2024
@mdiarra3 mdiarra3 merged commit 6af2802 into main May 23, 2024
2 checks passed
@mdiarra3 mdiarra3 deleted the LG-12357-translation-update-security-key-page branch May 23, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants