Proof of Concept: PIV upsell #10620
Closed
Proof of Concept: PIV upsell #10620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmdembe
commented
May 14, 2024
| @@ -37,6 +37,15 @@ def gov_or_mil? | |||
| email.end_with?('.gov', '.mil') | |||
| end | |||
|
|
|||
| def fed_agency_issues_piv? | |||
There was a problem hiding this comment.
Include .mil domains in this definition
aduth
reviewed
May 14, 2024
| @@ -37,6 +37,15 @@ def gov_or_mil? | |||
| email.end_with?('.gov', '.mil') | |||
| end | |||
|
|
|||
| def fed_agency_issues_piv? | |||
| email_domain = get_email_domain | |||
| IdentityConfig.store.federal_agencies_with_piv.include?(email_domain) | |||
There was a problem hiding this comment.
As mentioned in the corresponding write-up, I think we may want to do this lookup from a database table rather than a configuration value, since there could be thousands of domains.
Similar to what we do with populating and looking up within the DisposableDomain table for disposable domains.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to reproduce:
To skip the PIV upsell
gsa.govorarmy.milto see how this would work if the email is not in a dataset.To view the upsell
gsa.govorarmy.mildomain.