Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(feedback): Add feedback plugin annotations to catalog entities #1754

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(feedback): Add feedback plugin annotations to catalog entities #1754

wants to merge 1 commit into from

Conversation

yashoswalyo
Copy link
Contributor

@yashoswalyo yashoswalyo commented Dec 13, 2023 •
edited

Explain the feature/fix

These annotations enable feedback plugin integration on backstage

Does this PR introduce a breaking change

No

Ready-for-merge Checklist

  • Expected files: all files in this pull request are related to one feature request or issue (no stragglers)?
  • Does the change have appropriate unit tests?
  • Did tests pass?
  • Did you update or add any necessary documentation (README.md, WHY.md, etc.)?
  • Was this feature demoed and the design review approved?

deshmukhmayur
deshmukhmayur approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member

@deshmukhmayur deshmukhmayur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deshmukhmayur deshmukhmayur deshmukhmayur approved these changes

@riginoommen riginoommen Awaiting requested review from riginoommen

@hybridx hybridx Awaiting requested review from hybridx

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yashoswalyo @deshmukhmayur