Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protein_Calculator #308

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Protein_Calculator #308

wants to merge 7 commits into from

Conversation

Anjalih11
Copy link

@Anjalih11 Anjalih11 commented May 14, 2022

Description πŸ“œ

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
Fixes #285


Checklist βœ…

  • I follow Contributing Guidelines & Code of conduct of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I'm GSSOC'22 contributor
  • Have you added a working video of your calculator ?

Screenshots / Gif (Optional) πŸ“Έ


![a11](https://user-images.githubusercontent.com/78612291/168444902-af205df8-6fb0-4918-b460-a11b603fda07.jpeg)

@awesome-bot-app
Copy link


Thanks for opening the pull request @Anjalih11! I will look into it ASAP!
Till then you can improve your code & you can show your love by staring my repos πŸ˜‹.

Copy link
Author

@Anjalih11 Anjalih11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the filename
a11

Copy link
Collaborator

@Chayan-11 Chayan-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please work on the layout and also make it responsive. you need to add a readme folder to add features of your calculator and also attach your ss there itself.

@Chayan-11 Chayan-11 added changes Changes Requested and removed review_needed labels May 15, 2022
@Anjalih11
Copy link
Author

Anjalih11 commented May 18, 2022

readme.md
I have changed the layout and Color of the Design And made it Responsive. And above is the readme file.

###Screenshot
b1

###Responsive
b2
###demo
https://user-images.githubusercontent.com/78612291/169091171-f0e04b7c-2c96-452f-8785-90a6c8cf4887.mp4
@Chayan-11 Review the changes

@Anjalih11
Copy link
Author

Anjalih11 commented May 19, 2022

@vasu-1 Review this please.And merge it.

@Anjalih11 Anjalih11 requested a review from Chayan-11 May 20, 2022 05:52
Copy link
Collaborator

@Chayan-11 Chayan-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your Readme isn't integrated here yet. Please recheck.

@Anjalih11 Anjalih11 requested a review from Chayan-11 May 21, 2022 02:55
Copy link
Collaborator

@Chayan-11 Chayan-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you didn't get my point. only .html code is present here. Also check that you need to create a Protein_Calculator sub-directory inside Calculators folder and then simultaneously integrate you html code and readme. Please change accordingly.

Copy link
Collaborator

@Chayan-11 Chayan-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All you did was replicating the same thing in different folders. I never asked you to do that. just upload your .html file, .css and .js files along with Readme within the Calculator/ Protein Calculator sub-directory.

@Anjalih11 Anjalih11 closed this May 31, 2022
@awesome-bot-app
Copy link


Thanks for closing this pull_request and contributing to our repository @Anjalih11 ! We hope you loved to work with our repository πŸ˜‹.

@Anjalih11 Anjalih11 reopened this May 31, 2022
Copy link
Collaborator

@Chayan-11 Chayan-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes Changes Requested GSSoC22
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Protein Calculator
2 participants