Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting SCIM_CONFIG via env var #443

Open
ariep opened this issue May 14, 2024 · 1 comment · May be fixed by #444
Open

Allow setting SCIM_CONFIG via env var #443

ariep opened this issue May 14, 2024 · 1 comment · May be fixed by #444

Comments

@ariep
Copy link

ariep commented May 14, 2024

For configuring SCIM (user provisioning protocol) in Zulip, I need to set SCIM_CONFIG in settings.py. However, when I set SETTING_SCIM_CONFIG to the right value -- the string representation of a python dict -- this is written as a string value in settings.py. Reading entrypoint.sh, it seems SCIM_CONFIG could be added to its list of variables that take an array value, that would be the easy fix here.

Alternatively or additionally, it would help to extend the automatic detection in entrypoint.sh: it already checks if the value starts with [ or (; adding { to that would also cover this case.

@sevmonster sevmonster linked a pull request May 18, 2024 that will close this issue
@sevmonster
Copy link

sevmonster commented May 18, 2024

diff --git a/entrypoint.sh b/entrypoint.sh
index 11f0b00..18b5fd6 100755
--- a/entrypoint.sh
+++ b/entrypoint.sh
@@ -282,6 +282,7 @@ zulipConfiguration() {
            [ "$setting_key" = "SOCIAL_AUTH_SAML_ENABLED_IDPS" ] || \
            [ "$setting_key" = "SOCIAL_AUTH_SAML_ORG_INFO" ] || \
            { [ "$setting_key" = "LDAP_APPEND_DOMAIN" ] && [ "$setting_var" = "None" ]; } || \
+           [ "$setting_key" = "SCIM_CONFIG" ] || \
            [ "$setting_key" = "SECURE_PROXY_SSL_HEADER" ] || \
            [[ "$setting_key" = "CSRF_"* ]] || \
            [ "$setting_key" = "REALM_HOSTS" ] || \

I've had this in my local copy for a long time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants