Update helm dependency versions, pull from full bitnami index #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitnami has in the past pulled old versions from their archive index (bitnami/charts#10539), breaking existing charts. Pull from the full archives hosted on Github.
klardotsh
approved these changes
Mar 6, 2023
| tags: | ||
| - redis | ||
| version: 16.8.7 | ||
| version: 17.7.4 |
There was a problem hiding this comment.
For paper trail's sake, Bitnami claims this major version upgrade is fairly uninteresting unless Redis 7 is known to break your application: https://github.com/bitnami/charts/blob/main/bitnami/redis/README.md#to-1700
| tags: | ||
| - rabbitmq | ||
| version: 8.32.0 | ||
| version: 11.9.1 |
There was a problem hiding this comment.
I guess since end users can choose whether or not to upgrade to our new charts, upstream's notes about major changes in this upgrade path probably shouldn't block this? Noting that link anyway.
|
this should probably be updated to use the OCI registry: https://blog.bitnami.com/2023/04/httpsblog.bitnami.com202304bitnami-helm-charts-now-oci.html |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #383.