Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use uWS in Socket.io? #129

Open
kurtextrem opened this issue Mar 16, 2018 · 2 comments
Open

Use uWS in Socket.io? #129

kurtextrem opened this issue Mar 16, 2018 · 2 comments

Comments

@kurtextrem
Copy link

See this issue on why: socketio/engine.io#388
And here how: https://github.com/socketio/engine.io#methods

@lukeed
Copy link
Collaborator

lukeed commented Mar 16, 2018

We technically could, but the performance aspect doesn't matter at all in JARVIS. Memory efficiency would be the only benefit.

Personally I'd probably swap to ws for this project since it's a little lighter on the install (no binary) and there's still a lot of performance improvement.

That said, we'd need to add a websocket listener on the client, which Sockette could do.

All in all, this is mostly a yak shaver because we don't really gain anything from it. It's not like JARVIS is powering an application server or something -- then it'd matter 😄

@zouhir
Copy link
Owner

zouhir commented Mar 20, 2018

I totally don't like socket.io but I can't prioritise swapping it now as we still in beta and am really rethinking so many things

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants