-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try out pre-commit.ci #1031
Labels
Comments
Thanks, happy to see that |
For what is worth: See https://github.com/plone/meta/blob/main/config/default/pre-commit-config.yaml.j2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
FEATURE EXPERIMENT
What I did:
I hear some complaints about the necessity of commits to make flake8 or the other code checkers happy.
What I expect to happen:
Most of the issues could be fixed by a machine, so it should do it.
What actually happened:
I have to run
tox
before the commit to see the problems which will arise in CI.Suggestions
pre-commit
to run the code checkers.pre-commit
to automatically see the problems when committing and get them fixed if they are automatically fixable.unittest
assert calls.Notes
tox -elint
to runpre-commit
on all files to use the same configuration and to allow to keep existing habits.pre-commit
.lint
environment.Zope
repository should be part of it.The text was updated successfully, but these errors were encountered: