Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change pack_date interpretation? #358

Open
d-maurer opened this issue Jan 19, 2022 · 0 comments
Open

Change pack_date interpretation? #358

d-maurer opened this issue Jan 19, 2022 · 0 comments

Comments

@d-maurer
Copy link
Contributor

Currently, FileStorage.pack deletes non current states when they have been created before pack_date (the parameter is aktually named t, a timestamp).

While this leads to an easy implementation, it does not conform to the intuitive interpretation: I have the complete history up to pack_date (and can revert up to this date). For this, we would need one additional older state.

With the current interpretation, even a very old pack_date does not guarantee that a very recent modification (to a very stable object) can be reverted.
Should we change the pack_date itnerpretation to include one additional older state?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant