Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serde_cbor is unmaintained #728

Open
alekitto opened this issue Mar 28, 2022 · 2 comments
Open

serde_cbor is unmaintained #728

alekitto opened this issue Mar 28, 2022 · 2 comments

Comments

@alekitto
Copy link
Contributor

This project still uses serde_cbor which has been abandoned by its author and its repository has been archived.
Unfortunately that library sometimes fails to decode valid cbor streams, which is the cause of errors like the one reported on #643.

This is not an issue right now as supported ES versions produce outputs decodable from the library, but potentially could be in the future.

The author proposed two alternatives:

  • minicbor
  • ciborium

RUSTSEC-2021-0127

@eeeebbbbrrrr
Copy link
Collaborator

Thanks for the heads-up on this. It's clearly something I hadn't realized. We probably need to fix up pgx as well.

@eeeebbbbrrrr
Copy link
Collaborator

Circling back to this... I spent some time many months ago looking into minicbor and ciborium and they failed pretty quickly with ZDB. I suppose either they're not perfect cbor impls or ES is sending something incorrect that serde_cbor can handle.

I'm not exactly sure what to do. I once considered just taking over serde_cbor maintenance, but at the end of the day, I don't have time to maintain it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants