Skip to content
This repository has been archived by the owner on Apr 27, 2020. It is now read-only.

Quotes used for params kubectl disappear #58

Open
gs11 opened this issue Dec 18, 2018 · 4 comments
Open

Quotes used for params kubectl disappear #58

gs11 opened this issue Dec 18, 2018 · 4 comments

Comments

@gs11
Copy link

gs11 commented Dec 18, 2018

Is this a BUG REPORT or FEATURE REQUEST?:

  • bug

What happened:
Quotes used for a json patch disappear and kubectl fails because unparseable command.
kubectl patch --namespace <namespace> statefulset <namespace> --type=json -p=[{op: replace, path: /spec/template/spec/containers/0/image, value:<image>}]

error: unable to parse "[{op:": yaml: line 1: did not find expected node content

What you expected to happen:
They'd be preserved in order for kubectl to work

How to reproduce it (as minimally and precisely as possible):
Use a kubectl params like:
patch --namespace <namespace> statefulset <statefulset> --type=json -p='[{"op": "replace", "path": "/spec/template/spec/containers/0/image", "value":"<image>"}]'

Anything else we need to know?:
Tested multiple ways of escaping the line without success

Environment:

  • Concourse CI version: (use fly --version): 3.14.1
  • kubernetes-resource image version: 1.12
  • Others:
@gs11 gs11 changed the title Quotes used for Quotes used for params kubectl disappear Dec 18, 2018
@superbrothers
Copy link
Contributor

Thank you for reporting. I'll check it out.

@superbrothers
Copy link
Contributor

Anyway, you can use kubectl set image command instead.

@gs11
Copy link
Author

gs11 commented Dec 20, 2018

Thanks, I didn't actually know that you could use set image for statefulsets. Just need to figure out how to pass the image path & version (from previous tasks) into the params.kubectl.

@superbrothers
Copy link
Contributor

I was wrong. kubectl set image can not change the image of statefulset 😓

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants