Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS notifications #17

Open
alexreg opened this issue Dec 19, 2020 · 6 comments
Open

macOS notifications #17

alexreg opened this issue Dec 19, 2020 · 6 comments
Labels
enhancement New feature or request

Comments

@alexreg
Copy link

alexreg commented Dec 19, 2020

A nice feature (maybe you have it planned?), would be for system notifications (i.e., macOS-integrated). Ideally they could be configured in Preferences with checkboxes for various types of notifications, like:

  • Found X packages out-of-date (maybe a sub-checkbox for displaying a notification when no outdated packages are found)
  • Beginning download of PKG
  • Finished download of PKG
  • Beginning install of PKG
  • Finished install of PKG
  • Error downloading/installing PKG
  • Overall summary (number of packages successfully updated, failed, etc.)
@zkokaja
Copy link
Owner

zkokaja commented Dec 21, 2020

Thanks for the ideas! Currently you get a notification if any packages are outdated. It would be very simple to update it to include the number of packages (or a new notification if there are no packages to update).

The package-specific notifications may be difficult because Brewlet just invokes the brew upgrade command, but maybe there's a workaround. Worst case would be to invoke upgrade on each package separately but that sounds inefficient.

I like the idea of having an overall summary of what was updated. I'm not sure if that would be best as a notification or maybe a separate window this always shows the summary of the previous update.

@zkokaja zkokaja added the enhancement New feature or request label Dec 21, 2020
@alexreg
Copy link
Author

alexreg commented Dec 22, 2020

Oh, hmm. I seem to not even be getting those notifications. It could be because it's having problems with brewdo still though.

It may be a little inefficient to invoke upgrades on individual packages, but I suspect the launch time for brew will be dwarfed by the time it takes to individually upgrade each package in most cases. Another alternative is parsing stdout as it gets emitted. This is liable to break if they changed the output format, however. That said, you could probably submit a patch to brew itself for (streaming) JSON output or such. JSON output is already an option for several other commands, so I'm inclined to think they'd accept it (worth an ask).

A separate window would work, but personally I would prefer just a notification, even if it's slightly longer.

Thanks for considering this!

@zkokaja
Copy link
Owner

zkokaja commented Feb 17, 2021

I made the out-of-date notifications to be more descriptive in f4b6ab3. I also added an Open log menu item (#22) that shows all the brew output. Also, any errors will be sent as notifications. I'm hesitant to add more fine-grained notifications like began/finished installing because it would be an overwhelming amount of notifications. I'll happily reconsider it if there's more consensus on it, though.

@alexreg
Copy link
Author

alexreg commented Feb 17, 2021

Thanks for that; very glad to hear.

When I start up Brewlet now I see this indefinitely:

Screenshot 2021-02-17 at 17 52 33

Perhaps we should take discussion about this issue over to the other issue though, about brewdo.

@alexreg
Copy link
Author

alexreg commented Mar 14, 2021

Hi @zkokaja. Any update on the above?

@zkokaja
Copy link
Owner

zkokaja commented Mar 26, 2021

Hey, sorry no updates yet. I don't expect to be able to work on this project until later next month when my school semester comes to an end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants