Move exchange rate fetching to client #13028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lontivero
force-pushed
the
move-exchangerate-to-client
branch
from
baa9b18
to
9e3a483
Compare
kiminuo
reviewed
May 14, 2024
kiminuo
reviewed
May 14, 2024
kiminuo
reviewed
May 14, 2024
kiminuo
reviewed
May 14, 2024
kiminuo
reviewed
May 14, 2024
kiminuo
reviewed
May 14, 2024
kiminuo
reviewed
May 14, 2024
kiminuo
reviewed
May 15, 2024
Most of the providers are exchanges that block access to their api from Tor. That means that not all providers can be used when Tor is enabled.
lontivero
force-pushed
the
move-exchangerate-to-client
branch
from
953f8b4
to
9f56e4a
Compare
molnard
requested changes
May 15, 2024
molnard
requested changes
May 15, 2024
molnard
requested changes
May 15, 2024
molnard
reviewed
May 15, 2024
|
The question is: what to do if the client enables Tor and chose an exchange rate provider which cannot be reached with Tor? |
yahiheb
reviewed
May 15, 2024
We want to prevent identifying that a specific IP using Wasabi.
My suggestion is to do random timing and random useragent in case of Clearnet. It is good enough and Wasabi will be compatible with any exchange rate provider - win! |
Some providers reject the requests if they don't have an User-Agent header. Additionally, using a constant pattern for the requests could help to finger the clients so, we use "random" user agents.
that are unreacheable using tor. Add mempool.space as default provider.
lontivero
force-pushed
the
move-exchangerate-to-client
branch
from
2287bc0
to
3abed97
Compare
|
This is ready. |
lontivero
added a commit
that referenced
this pull request
May 21, 2024
* Create `ExchangeRateProvider2` * Remove old exchange rate providers and controllers * Fetch exchange rates from the client * Make exchange rate provider configurable * Fix warnings * Naming error * CR feedback * Use Tor to connect to providers Most of the providers are exchanges that block access to their api from Tor. That means that not all providers can be used when Tor is enabled. * Add `User-Agent` to requests Some providers reject the requests if they don't have an User-Agent header. Additionally, using a constant pattern for the requests could help to finger the clients so, we use "random" user agents. * Remove some exchange rate providers that are unreacheable using tor. Add mempool.space as default provider. * Add random delay between queries --------- Co-authored-by: Kiminuo <[email protected]>
lontivero
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify the exchange rate fetching mechanism and move it to the client (remove api from server).
Tor support is missing but the PR is enough to make configurable through the UI and to test.