CS8600 removal #12993
Merged
CS8600 removal #12993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/compiler-messages/nullable-warnings?f1url=%3FappId%3Droslyn%26k%3Dk(CS8600) Converting null literal or possible null value to non-nullable type. We can safely change the return value to string since the only caller just uses IsNullOrEmpty, don't differentiate between the two state (null vs empty string).
|
The Required part can be fixed by #12989 |
|
It looks to me that one can do 84079dc and given that there is only one caller, it should be safe. Could you check? |
kiminuo
approved these changes
May 12, 2024
csiki2
commented
May 12, 2024
| { | ||
| return ""; | ||
| } | ||
|
|
There was a problem hiding this comment.
Are you sure that we can do this?
Due to how it is used:
private string PreComposeText(string input)
{
input = RemoveInvalidCharacters(input);
var preComposedText = Text ?? "";
var caretIndex = CaretIndex;
var selectionStart = SelectionStart;
var selectionEnd = SelectionEnd;
if (!string.IsNullOrEmpty(input) && (MaxLength == 0 ||
It's a bit suspicious.
There was a problem hiding this comment.
I checked it and input looks non-null.
There was a problem hiding this comment.
Or can you see where it can become null?
There was a problem hiding this comment.
For me string.IsNullOrEmpty implies that it might be null, or was it there for no reason?
There was a problem hiding this comment.
Currently only used here:
protected override void OnTextInput(TextInputEventArgs e)
{
var input = e.Text == null ? "" : e.Text.TotalTrim();
You are right, this is never null. The code is simply misleading.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/compiler-messages/nullable-warnings?f1url=%3FappId%3Droslyn%26k%3Dk(CS8600)
Converting null literal or possible null value to non-nullable type.
We can safely change the return value to string since the only caller just uses IsNullOrEmpty, don't differentiate between the two state (null vs empty string).