Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Add Wallet - remove oobe backgroud #12982

Closed
wants to merge 1 commit into from

Conversation

soosr
Copy link
Contributor

@soosr soosr commented May 7, 2024

Closes #12715

This PR only removed the BG when adding a wallet. For welcome screens (and for the first wallet) it still be there as it has two purposes:

  • The wallet list is empty, there is nothing to show in the background, and it looks odd.
  • Make the initial experience more engaging and memorable for first-time users.

@soosr
Copy link
Contributor Author

soosr commented May 7, 2024

TBH the wallet creation is a very crucial process, it made sense to hide the background completely with the OOBE background. After this PR the user's attention is not 100% forced on the dialog.

This is my feedback, if the majority still insist on removing the BG, then go with it.

Copy link
Collaborator

@yahiheb yahiheb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After this PR the user's attention is not 100% forced on the dialog.

If the reason is to keep the users attention on the dialog, then it makes more sense to remove the OOBE for the welcome screens since the wallet list is empty as you stated above, so there is nothing that should take the user's attention.

My suggestion is to blurry out the background more and remove OOBE completely.

@soosr
Copy link
Contributor Author

soosr commented May 7, 2024

then it makes more sense to remove the OOBE for the welcome screens since the wallet list is empty as you stated

You didn't understand the point. It is totally empty. Even the the main screen navigation stack is empty. It just looks shit.
image

so there is nothing that should take the user's attention.

Obviously the empty background is more distracting than the OOBE bg.

My suggestion is to blurry out the background more and remove OOBE completely.

NACK, bad idea with more complexity for almost zero benefit.

@yahiheb
Copy link
Collaborator

yahiheb commented May 7, 2024

Obviously the empty background is more distracting than the OOBE bg.

Really? OOBE now has these moving elements (circles and shapes with different colors) which is definitely more distracting than an empty background.

If there is no benefit to blurry out the background or to make the window smaller to only show the dialog (as suggested by Dan) then there is no user distraction as claimed, and thus no need to use OOBE in the first place.

For the complexity argument you and I both know that there are far more unnecessary complexities all over the UI, for example the welcome screens themselves.

@MaxHillebrand
Copy link
Collaborator

How about a solid dark color as OOBE background?

@soosr
Copy link
Contributor Author

soosr commented May 7, 2024

This starting to smell like Minefield.

@soosr soosr closed this May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get rid of the OOBE (out of box experience background)
3 participants