-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unconfirmed chain #12973
Remove unconfirmed chain #12973
Conversation
Remove chain analysis querying
Legal documents have no place here because zkSNACKs is not going to provide any service related to coinjoins, only develop software.
[FOSS] Remove CJ fee related contents
* Remove `CoinJoinIdStore` This was used mainly to implement the "remixes dont pay" feature, which was added late in the WabiSabi development as an idea to incentivize continue coinjoining, and as a marketing selling point. It was also used as a trivial optimization for the "friends don't pay" or "one hop don't pay" (what requires a full-index bitcoin node)
Wasabi coordinator doesn't charge any coordination fee by default. `Plebs don't pay threshold` is removed because it makes zero sense.
The coinjoin archiver is simple a logger and as such it should be implemented using the logging infrastructure.
It is not used by the wallet.
* Create `ExchangeRateProvider2` * Remove old exchange rate providers and controllers * Fetch exchange rates from the client * Make exchange rate provider configurable * Fix warnings * Naming error * CR feedback * Use Tor to connect to providers Most of the providers are exchanges that block access to their api from Tor. That means that not all providers can be used when Tor is enabled. * Add `User-Agent` to requests Some providers reject the requests if they don't have an User-Agent header. Additionally, using a constant pattern for the requests could help to finger the clients so, we use "random" user agents. * Remove some exchange rate providers that are unreacheable using tor. Add mempool.space as default provider. * Add random delay between queries --------- Co-authored-by: Kiminuo <[email protected]>
* Add `FeeRateProvider` * Add `FeeRateEstimationUpdater` * Make fee estimation provider configurable * Replace `HybridFeeProvider` with `FeeRateEstimationUpdater` * Add User-Agent, Log entry and small refactoring
* Remove custom request timeouts mechanism * Remove unused things
Refactor UpdateManager and remove UpdateChecker
2be6438
to
63c8e37
Compare
There are two independent APIs: * WabiSabi for coinjoining and, * Wallet required for providing services to the wallet client to operate.
This reverts commit 176c7df.
* Organize the API There are two independent APIs: * WabiSabi for coinjoining and, * Wallet required for providing services to the wallet client to operate. * Make `/synchronize` a synchronous method
…ctory` (WalletWasabi#13052) CoinJoinProcessor: Pass dependencies properly
63c8e37
to
11290ec
Compare
11290ec
to
bf3b786
Compare
I've been rebasing this PR to keep it mergeable at any time but I would like to see if it is possible to remove the backend API without removing the feature. |
I've reconsidered the situation of this feature. It is true that as it is it allows DoS and that it doesn't let us use Wasabi with a prune node but the functionality that it provides cannot be achieved otherwise by the moment so, in the meanwhile we should let it as it is and in case the operator wants to run the backend with a pruned node the feature can be simply unavailable. |
I was planning to move this feature to mempool.space but didn't have the time yet with all the other contexts, don't you think that it would be a correct solution here? Privacy wise, I think it's better to ask to mempool.space rather than a small backend provider because on mempool.space many non wasabi users request this endpoint |
Reverts: #12318 #12302