-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UI] Update avalonia 11.1.0 #12926
base: master
Are you sure you want to change the base?
[UI] Update avalonia 11.1.0 #12926
Conversation
@zkSNACKs/testing-team Please do a thorough test here. Here are the issues that are worth testing if get fixed: https://github.com/orgs/zkSNACKs/projects/18/views/57 |
On NuGet main servers https://www.nuget.org/packages/Avalonia/11.1.0-beta1 |
Updated to latest Avalonia 11.1.0-beta2 |
Is it wise to update to beta versions?
I checked that board and it seems only #12678 is maybe worth fixing, the others are low priority. |
We are already shipping with nightly builds of Avalonia :) There is a lot of improvements and bug fixes between 11.0 and 11.1. |
True, but isn't this the source of bugs that keep coming back and we keep fixing them over and over? |
The UI team agreed to only update Avalonia if it is stable or at least it fixes some of our issues, instead of introducing a new one.
And this is the point when the @zkSNACKs/testing-team comes into the picture... to run some tests on this PR. |
We can never be sure this doesn't introduce new bugs unless we test this extensively, and even if we do we always get new ones (at least from many past experiences). Do you want the test-team to go through the whole application and test every bit of it just for #12849 which seems to be not so relevant issue? PRs/features are best tested by those who write the code and know what parts of the software are affected by their changes. |
Here you can read the main changes https://github.com/AvaloniaUI/Avalonia/releases, we are currently on a version that is between 11.0.9 and 11.0.10.
Yeah obviously it can happen some other parts will be broken, that is why we are here... to test it, report the issues to Avalonia, get them fixed, make sure everything is fine, and only update when we are sure.
No. The Developer and Testing team both have their responsibilities. The developer is responsible for the initial testing to make sure everything they changed works well. Once that is done then comes the testing team. Who's responsibility is double-checking that the new feature that the developer introduced works well and also to check that the changes work well with the existing system, meaning it did not break the existing parts. Since this PR updates the Avalona version, which literally touches the whole UI, and also taking the fact that the developer is on Mac and the testing team contains one Windows user and one Linux user, it would make a lot of sense for these 3 people to click through the application, and test it since there is no other way of testing it. |
@wieslawsoltes The titlebar is broken on windows, cannot drag the application, the close, minimize, full screen buttons are missing. |
Looks like a bug in 11.1.0-beta2 could also repro |
This reverts commit 3a4ea91.
@soosr Reported the issue AvaloniaUI/Avalonia#15522 |
It's not using 11.1.0-beta2 but should just work
TODO: