Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPFP speedups notify the user of a "self transfer" #12969

Closed
Kruwed opened this issue May 4, 2024 · 3 comments · Fixed by #13061
Closed

CPFP speedups notify the user of a "self transfer" #12969

Kruwed opened this issue May 4, 2024 · 3 comments · Fixed by #13061
Assignees

Comments

@Kruwed
Copy link
Collaborator

Kruwed commented May 4, 2024

Credit @Bodnaralexa

Even though a CPFP is technically a self transfer transaction, it is better to notify the user with a less conceptual message like "Transaction accelerated".

@GeetaCX
Copy link

GeetaCX commented May 5, 2024

Seems simple to implement, Just a label on the transaction.

What do you mean by "notify"? Is that a popup or in the TX history?

@Kruwed
Copy link
Collaborator Author

Kruwed commented May 5, 2024

Seems simple to implement, Just a label on the transaction.

Labels are a different thing.

What do you mean by "notify"? Is that a popup or in the TX history?

It's a popup flag in the bottom right corner of the screen, you can see it appear at 0:30 in this clip:

bandicam.2024-05-05.12-32-26-922.mp4

@soosr
Copy link
Collaborator

soosr commented May 6, 2024

Even though a CPFP is technically a self transfer transaction, it is better to notify the user with a less conceptual message like "Transaction accelerated".

We are very strict with the notifications, meaning they are only used for notifying about transactions.
Transaction accelerated is feedback about the result of a process.
To follow the convention it could be Accelerator transaction which would make more sense in the case it gets confirmed as it would say Accelerator transaction confirmed instead of Transaction accelerated confirmed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants