Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zk init generates ambigous LSP section in config #413

Open
notramo opened this issue May 18, 2024 · 1 comment
Open

zk init generates ambigous LSP section in config #413

notramo opened this issue May 18, 2024 · 1 comment
Labels
bug Something isn't working
Milestone

Comments

@notramo
Copy link

notramo commented May 18, 2024

Describe the bug

The LSP section in the zk init generated config file is ambigous.
I don't know what are the possible values for the lsp.completion section.

Are the possible values the empty strings? (so it's enough to delete the comment marks at the line beginning?)

[lsp.completion]
# Customize the completion pop-up of your LSP client.

# Show the note title in the completion pop-up, or fallback on its path if empty.
#note-label = ""
# Filter out the completion pop-up using the note title or its path.
#note-filter-text = " "
# Show the note filename without extension as detail.
#note-detail = ""

How to reproduce?

Run zk init and see .zk/config.toml

zk configuration

Vanilla config generated by zk init

Environment

any
@tjex
Copy link
Member

tjex commented May 21, 2024

lsp config is documented here in the repo.

I agree it would be good to populate these with sane defaults, and leave them commented out.

Starting point would be here

But actually, the default config does have content within the quotes... And on my end zk init also generates a conf with empty values within the quotes.

tis a bug!

@tjex tjex modified the milestones: 0.15.0, 0.14.2 May 21, 2024
@tjex tjex added the bug Something isn't working label May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants