New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A more complete parser for tag filtering? #231

Open

wrvsrx opened this issue Jun 30, 2022 · 1 comment

Labels

feature request

Contributor

wrvsrx commented Jun 30, 2022

It seems that tag filter only supports simple logical operation now. Maybe It can support complete logical expression such as

zk list -t '(NOT aaa) OR bbb'

However, supporting complex login expression needs rewriting expression parser (https://github.com/mickael-menu/zk/blob/68e6b70eaefdf8344065fcec39d5419dc80d6a02/internal/adapter/sqlite/note_dao.go#L554-L600) and allow some escape character. I don't think it's very important though, just give this issue a low priority.

mickael-menu added the feature request label

Member

mickael-menu commented Jul 1, 2022

I won't implement this myself but I'll welcome PRs if someone needs this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment