Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZingTouch does not work with iOS 13 #70

Open
kmgwalker opened this issue Oct 16, 2019 · 5 comments
Open

ZingTouch does not work with iOS 13 #70

kmgwalker opened this issue Oct 16, 2019 · 5 comments

Comments

@kmgwalker
Copy link

The demo page is unresponsive with ios 13 (ipad and iphone). Works fine with ios 12 (ipad).

@Xerotherm1c
Copy link

Seems like this should be a top priority bug to fix - the latest iOS not working?? I found that hammer.js has some feature conflicts with iOS13 (documented here). One of the comments reads:

Try to turn off the following setting

Settings -> Safari -> Advanced -> Experimental Features -> Pointer Events

iOS 13 supports Pointer Event, so HammerJS seems to recognize Pointer Event instead of Touch.

@kmgwalker Can you (or anyone with iOS13) test the ZingTouch examples with this setting turned off? I do not have an iOS13 device handy.

@whoacowboy
Copy link
Collaborator

I agree, this is pretty big. I started to look into it, but got side tracked with work.

You can test on a Mac with a trackpad and safari as well.

This is what I came across as a starting point.

function zoom(e) {
  console.log(e.scale)
  e.preventDefault()
}
document.addEventListener('gesturestart', zoom)
document.addEventListener('gesturechange', zoom)
document.addEventListener('gestureend', zoom)

I am goin to look into it again, once I have some more time. Any insights you find or PRs would be great.

@Xerotherm1c
Copy link

I was able to get my hands on an iPhone 7 running iOS 13.3.1 and the specific code example that does not work is the rotation example. Every other example works on this device, though the pinch-and-zoom graphing example appears to require focus before pinching-and-zooming.

I confirmed that disabling Pointer Events inside Safari's Experimental Settings fixes the otherwise-broken rotation example with both one or two fingers. I am unsure if this will likewise fix any otherwise-broken functionality in hammer.js, but given that I picked that tip up from a reported hammer.js issue, it's likely that this setting is the sole reason these libraries are (partially) broken in iOS13. Hopefully additional developers can cross-confirm these results and test other device models with various iOS13 minor versions, as I no longer have access to the iOS13 device.

@kmgwalker
Copy link
Author

kmgwalker commented Apr 18, 2020

iOS 13.3.1, iphone 11: On the demos on https://zingchart.github.io/zingtouch/ , (1) 1 and 2-finger taps work, (2) rotate does not work, (3) pinch/expand does NOT work (one must distinguish (a) expanding only the chart DOM element from(b) the mobile-safari-built-in expansion of the entire web page), and (4) flicking bubbles does not work (one can make a bubble hold still, but one cannot send it in a new direction).

** With point events turned off (as described above), all of the examples work

@kylebakerio
Copy link

any news on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants