-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No option to remove the slider thumb from the 'tab flow' #308
Comments
I found that the thumb props contain
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
If I set the
disabled
prop on react-slider I cannot move the thumb but I can still tab to it.In the code sandbox I have set up you'll see I've set the
disabled
prop on react-slider and that it can still be tabbed to. For comparison I've included a native 'range slider' control that has thedisabled
attribute set - note that you cannot tab to it.I know there is a certain amount of debate as to whether disabled controls should still be part of the 'tab flow' or not - from what I can figure out there seems to be some consensus that buttons and links should be part of the tab flow even when disabled but other form controls typically shouldn't be.
Regardless of where you stand on that, there will still always be situations when there's a good reason to remove a control from the tab flow - so if you want to argue that this shouldn't be tied into the
disabled
attribute but instead should be controlled separately... I'd be inclined to agree with that!Note that removing the thumb from the tab flow doesn't prevent it from being accessed by assistive technologies like screen readers - they can still navigate to it fine.
CodeSandbox
https://codesandbox.io/s/react-slider-kybd-a11y-rcmvy6
The text was updated successfully, but these errors were encountered: