Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

todo: get rid of the function, bad design #565

Open
alexanderguzhva opened this issue May 13, 2024 · 1 comment
Open

todo: get rid of the function, bad design #565

alexanderguzhva opened this issue May 13, 2024 · 1 comment

Comments

@alexanderguzhva
Copy link
Collaborator

alexanderguzhva commented May 13, 2024

https://github.com/zilliztech/knowhere/blob/main/src/common/utils.cc#L75-L87

completely eliminate this function!

Put it inside .train() calls

Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

@github-actions github-actions bot added the stale label Jun 13, 2024
@liliu-z liliu-z closed this as completed Jun 13, 2024
@liliu-z liliu-z reopened this Jun 13, 2024
@liliu-z liliu-z removed the stale label Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants