Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve the iterator implementation #500

Open
zhengbuqian opened this issue Apr 16, 2024 · 2 comments
Open

improve the iterator implementation #500

zhengbuqian opened this issue Apr 16, 2024 · 2 comments

Comments

@zhengbuqian
Copy link
Collaborator

so that we can avoid as much duplicate code between indexes as possible and form a good foundation for Cardinal to add iterator support

@zhengbuqian
Copy link
Collaborator Author

zhengbuqian commented Apr 16, 2024

TODOs after #501:

  • hnsw iterator use brute force for high filter rate
  • hnsw iterator to limit to_visit size by search 1 step every several Next() calls.
  • ivf iterator to copy and own query data
  • DiskANN iterator impl
  • IVF-SQ8 iterator impl: this is being targeted in Add iterator for ivf_sq_8 #414
  • HNSW impl has support for binary vector, but it is not officially supported. Thus hnsw iterator on binary vector is not properly tested: this is being targeted in hnsw support fp16/bf16 #494
  • make the parameters configurable

Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

@github-actions github-actions bot added the stale label May 20, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 27, 2024
@zhengbuqian zhengbuqian reopened this May 27, 2024
@github-actions github-actions bot removed the stale label May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant